chore(deps): bump @p2pdotme/sdk to 1.2.7 (subject-bound signatures) - #69
Draft
Software-Artist-Aash wants to merge 3 commits into
Draft
chore(deps): bump @p2pdotme/sdk to 1.2.7 (subject-bound signatures)#69Software-Artist-Aash wants to merge 3 commits into
Software-Artist-Aash wants to merge 3 commits into
Conversation
Picks up p2pdotme/p2pdotme-sdk#52, which binds the subject address into the fraud-engine EIP-191 signed message: `{action}:{signer}:{subject}:{ts}` instead of `{action}:{signer}:{ts}`. No application code changes. Both addresses were already carried on FraudEngineSigner, so the change is internal to getSignedHeaders and this repo only needs the dependency. Part of the fraud-engine wallet-auth fix (p2pdotme/fraud-engine#41), where the backend additionally verifies on-chain that the signer is an admin of the subject smart account. The backend accepts both message formats during rollout, so this carries no ordering constraint against any other client. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1.2.7 was already published from an unrelated change and does not contain the wallet-signature subject binding, so pinning it would be a silent no-op. 1.2.8 is the release that carries it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
widgets CI installs with `npm ci`, which refuses to run when package.json and the lock disagree: Invalid: lock file's @p2pdotme/sdk@1.1.6 does not satisfy @p2pdotme/sdk@1.2.8 The bun-based clients don't need this -- bun install resolves and rewrites the lockfile even with CI=true -- but npm ci is strict, so widgets does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump only — picks up p2pdotme/p2pdotme-sdk#52, which binds the subject address into the fraud-engine EIP-191 signed message.
Why
The signed message was
{action}:{signer}:{ts}— it committed to the signing key but not to the account the request acts for. For AA smart wallets the signer is the admin EOA while the subject is the smart account, so a signature captured for one account was replayable against another inside the backend’s 5-minute freshness window. Now:{action}:{signer}:{subject}:{ts}.No application code changes
Both addresses were already carried on
FraudEngineSigner(address= subject,signerAddress= admin EOA), so the change is entirely internal togetSignedHeaders. This repo only needs the dependency.@p2pdotme/sdk@1.2.7is not published; npm is still on 1.2.6. Before merging:package.jsonContext
Part of the fraud-engine wallet-auth fix (p2pdotme/fraud-engine#41), where the backend additionally verifies on-chain that the signer is an admin of the subject smart account — that is the control that actually closes the hole; the message binding is defence in depth against cross-subject replay.
The backend accepts both message formats during rollout, so there is no ordering constraint against any other client and no window where anything breaks.
🤖 Generated with Claude Code